Log RequestOptions params#1070
Merged
jacalata merged 2 commits intotableau:developmentfrom Jul 28, 2022
Merged
Conversation
Contributor
|
@jorwoods this looks like a nice addition. Any concerns about logging sensitive information here? I believe at the DEBUG level we're already logging the full request & response, so adding this doesn't log anything new or worse. |
Contributor
Author
|
@bcantoni I thought about this and do not think it will contain sensitive information. All of the sensitive information that gets passed is in the body of requests, not in what gets passed as part of the query string. (Unless there is a case I am forgetting about) |
bcantoni
approved these changes
Jul 28, 2022
Contributor
bcantoni
left a comment
bcantoni
left a comment
There was a problem hiding this comment.
I agree - also it's only under debug level which is logging a bunch from all the other requests. Nice addition!
jacalata
added a commit
that referenced
this pull request
Sep 12, 2022
* Datasources: Use explicit None identity check for datasource updates (#1099) (Resolves #1062 - cannot set empty password) * Projects: add publish-samples option to create/update project * Workbooks: fix workbook.delete_extract, add workbook pdf download, make project_id nullable to support "Personal Space", Remove vf support from populate_excel, make hidden views an attribute of Workbooks and deprecate hidden_views flag in publish request * Schedules: add get_by_id method * Users: Reassign content on user removal, add user import logic * Jobs: Add Status, ParentProjectId and StartedAt filters, Extract refreshable item IDs from job XML response * Sites: Add version awareness to site create/update methods: Update sites requests for Breaking change in 3.10: flowsEnabled removed, flowsEditingEnabled and flowsSchedulingEnabled added ,Allow setting site user_quota to None if tiered licenses exist * Do not eagerly fetch content when a stream was requested * create single Credentials class (#1032), Included redacted print methods for each credential type * on init set use_server_version = False so that we don't try and contact the server before people finish setting certs * add client version/debug header * Logging: log RequestOptions params (#1070), add redaction method to remove passwords when logging requests and responses, which can contain embedded credentials, log the url of the request that got an error in the response. * fix filter for python 3, remove support for python 3.6 (add python version enforcement in setup.py) * Fix slicing logic, add tests for queryset slicing crossing a page, add support for len magic method to queryset * Add type hints for workbook and data source revisions, data alerts, Favorites, Flows, groups, permissions, projects, sites, subscriptions, Users, webhooks * Samples: fix export sample, delete redundant samples (export_wb, download_view_image), add user import sample, default permissions sample * add publish to pypi actio, enable Black for CI, consolidate config files into pyproject.toml co-authored-by: Amar Yadav <AmarKumar.Yadav@genmills.com> Co-authored-by: Jac <jacalata@users.noreply.github.com> Co-authored-by: Stephen Mitchell <scum@mac.com> Co-authored-by: jorwoods <jorwoods@users.noreply.github.com> Co-authored-by: Brian Cantoni <bcantoni@salesforce.com> Co-authored-by: Tyler Doyle <doyle.tyler@gmail.com> Co-authored-by: bcmyguest1 <49045013+bcmyguest1@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Write RequestOptions params to debug log. This is helpful when troubleshooting requests to see how filters get applied.