Skip to content

License text not included in source distribution #224

@akaihola

Description

@akaihola

The LICENSE file in this tableau/server-client-python repository contains the MIT license text. When building a source .tar.gz distribution, the file is omitted:

$ git clone -q https://github.com/tableau/server-client-python.git
$ cd server-client-python
$ python setup.py sdist
running sdist
[...]
Creating tar archive
removing 'tableauserverclient-0.4.1' (and everything under it)

$ tar tvf dist/*.tar.gz | egrep 'LICENSE|setup\.py|MANIFEST\.in'
-rw-rw-r-- myself/myself   754 2017-09-19 13:25 tableauserverclient-0.4.1/setup.py
-rw-rw-r-- myself/myself    62 2017-09-19 13:25 tableauserverclient-0.4.1/MANIFEST.in

As a result, also the tarball downloadable from PyPI doesn't contain any license text:

curl https://pypi.python.org/packages/95/f6/36b4a43a41af2cb01b74a0a047fd4d7108af72ff1a351adca12b37647732/tableauserverclient-0.4.1.tar.gz \
| tar tz \
| egrep 'LICENSE|setup\.py|MANIFEST\.in'
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 55277  100 55277    0     0   149k      0 --:--:-- --:--:-- --:--:--  149k
tableauserverclient-0.4.1/MANIFEST.in
tableauserverclient-0.4.1/setup.py

The only mention of the license in the source distribution is license='MIT' in setup.py, which is not sufficient. I believe this omission prevents e.g. our company from installing the library on our customers' servers.

For an example of how to ensure inclusion of the license file, please see the Python Packaging User Guide and the sample project it provides containing the MANIFEST.in and setup.py files.

Also, it seems that versioneer.py isn't distributed under the MIT license, but CC0-1.0. Is it actually necessary to include versioneer.py in MANIFEST.in and thus in the source distribution, since it has already done its job at that point? The _tableauserverclient/_version.py it generates gets included (and that file by the way is also under CC0-1.0). That license is not mentioned in setup.py.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions