Skip to content

Use spec-consistent property names #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

danny0838
Copy link
Contributor

@danny0838 danny0838 commented Apr 4, 2024

The spec says type flag for some tokens, while this module outputs isInteger, isIdent, etc. instead, which is not consistent.

Unfortunately the type property is already used to determine the token/rule type. A simple workaround is to use TYPE instead, as this special property is mostly used for the JSON output (in other context we can simply check by obj instanceof theTokenClass or obj.constructor.name === theTokenClass.name instead).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant