Dft interface, backend dispatching and mklgpu implementation stubs#1
Open
Dft interface, backend dispatching and mklgpu implementation stubs#1
Conversation
Rbiessy
reviewed
Sep 27, 2022
mehdi-goli
reviewed
Sep 27, 2022
Owner
Author
|
@mehdi-goli @Rbiessy I addressed the comments. Can you check if there is anything else you would like changed here or is it ok as it is now? |
|
It looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added dft interface, backend dispatching for it and mklgpu implementation stubs.
Checklist
All Submissions