Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make gocmd compile even if GOPATH is not defined #40

Merged
merged 3 commits into from
Jun 20, 2014
Merged

Make gocmd compile even if GOPATH is not defined #40

merged 3 commits into from
Jun 20, 2014

Conversation

nanomad
Copy link
Contributor

@nanomad nanomad commented May 5, 2014

This PR makes gocmd build system more flexible:

  • It will build even if there's no GOPATH defined in the user's environment. The build system will silently create one nested inside the source folder.
  • It allows for a custom executable name
  • It allows for the above settings to be persisted inside config.mk (which is not tracked by git)
  • Makes test target depend on build (so that you can just run make test)
  • Adds a clean target to delete build artifacts

I've added a .gitignore file so that generated files do not appear as "untracked" in git status

nanomad added 3 commits May 5, 2014 09:32
Allow users to specify a custom local GOPATH and executable name
Settings should be added to config.mk which is not tracked by the build
system
@nanomad
Copy link
Contributor Author

nanomad commented May 5, 2014

Uhm I didn't realize that PR gets automatically updated by github with new commits, I've updated the description and title accordingly

t3rm1n4l added a commit that referenced this pull request Jun 20, 2014
Make gocmd compile even if GOPATH is not defined
@t3rm1n4l t3rm1n4l merged commit dd48212 into t3rm1n4l:master Jun 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants