Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
marxtin
requested review from
birterohden,
Copilot,
fl0uW,
itscursedphil and
veldhaenchen
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes internal URLs to include trailing slashes and slightly adjusts several component type declarations to better reflect their actual props.
Changes:
- Updated various navigation, footer, header, storybook, and user menu links to use trailing slashes in their href/action URLs.
- Adjusted
Ratio.d.tsto explicitly include theratioprop in the styled component type and align it withRatioProps. - Updated
Link.d.ts,HoverLink.d.ts, andIcon.d.tsto expose atypeprop and include it in the StyledComponent generic typing.
Reviewed changes
Copilot reviewed 8 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/storybook/src/stories/components/layout/pageLayout.stories.tsx | Storybook brand teaser URL updated to /technology-review/ to match trailing-slash convention. |
| packages/storybook/src/stories/components/layout/pageHeader.stories.tsx | Storybook header brand teaser URL updated to /technology-review/ with trailing slash. |
| packages/components/src/UserMenu/UserMenu.tsx | Default account-related links (login, logout, abo, reading list, account edit) updated to trailing-slash URLs. |
| packages/components/src/Ratio/Ratio.d.ts | Declaration updated so the styled Ratio component explicitly carries ratio: RatioProps["ratio"] and includes "ratio" in its prop key union. |
| packages/components/src/PageHeader/components/BurgerNav.tsx | Burger navigation account, search, subscription, podcast, and events links/actions switched to trailing-slash URLs. |
| packages/components/src/PageHeader/PageHeader.tsx | Header subscription / abo-landing links updated to /dein-abo/ and /abos/. |
| packages/components/src/PageFooter/MobileFooter.tsx | Mobile footer navigation links for abo, abos, team, jobs, and abo cancellation updated to trailing-slash URLs. |
| packages/components/src/PageFooter/DesktopFooter.tsx | Desktop footer navigation links (team, jobs, abo cancel, dein-abo, abos, podcast, events, brandhub) adjusted to trailing slashes. |
| packages/components/src/Link/Link.d.ts | Link declaration extended so type is present in the base prop object and included in the StyledComponent prop key union. |
| packages/components/src/Link/HoverLink.d.ts | HoverLink declaration similarly updated to expose type and include it in the prop key union. |
| packages/components/src/LegacyBookmarkModal/LegacyBookmarkModal.tsx | Legacy bookmark modal registration button href updated to /account/register/. |
| packages/components/src/Icon/Icon.d.ts | Icon declaration updated to include a type string prop in the base props and prop key union. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
birterohden
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Checklist