Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: git spinner #621

Merged
merged 7 commits into from
Oct 17, 2022
Merged

fix: git spinner #621

merged 7 commits into from
Oct 17, 2022

Conversation

c-ehrlich
Copy link
Member

@c-ehrlich c-ehrlich commented Oct 17, 2022 •
edited by juliusmarminge
Loading

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

hopefully fixes the git spinner? leaving as draft for now

💯

@vercel
Copy link

vercel bot commented Oct 17, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
create-t3-app ✅ Ready (Inspect) Visit Preview Oct 17, 2022 at 8:07PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 5c95429

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the 📌 area: cli Relates to the CLI label Oct 17, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2022 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 100
🟢 Accessibility 100
🟢 Best practices 93
🟠 SEO 86
🟠 PWA 54

Lighthouse ran on https://create-t3-app-git-fix-spinner-t3-oss.vercel.app/

@c-ehrlich c-ehrlich added the 🚀 autorelease add this label to a pr to trigger a beta release label Oct 17, 2022
@juliusmarminge juliusmarminge removed the 🚀 autorelease add this label to a pr to trigger a beta release label Oct 17, 2022
@t3-oss t3-oss deleted a comment from github-actions bot Oct 17, 2022
@c-ehrlich c-ehrlich added the 🚀 autorelease add this label to a pr to trigger a beta release label Oct 17, 2022
@t3-oss t3-oss deleted a comment from github-actions bot Oct 17, 2022
@juliusmarminge juliusmarminge added 🚀 autorelease add this label to a pr to trigger a beta release and removed 🚀 autorelease add this label to a pr to trigger a beta release labels Oct 17, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2022 •
edited
Loading

A new create-t3-app prerelease is available for testing. You can install this latest build in your project with:

npx create-t3-app@6.0.0-beta.2f9146d

@github-actions github-actions bot removed the 🚀 autorelease add this label to a pr to trigger a beta release label Oct 17, 2022
@juliusmarminge juliusmarminge added the 🚀 autorelease add this label to a pr to trigger a beta release label Oct 17, 2022
@github-actions github-actions bot removed the 🚀 autorelease add this label to a pr to trigger a beta release label Oct 17, 2022
@c-ehrlich c-ehrlich marked this pull request as ready for review October 17, 2022 20:03
@c-ehrlich c-ehrlich marked this pull request as draft October 17, 2022 20:04
@c-ehrlich c-ehrlich marked this pull request as ready for review October 17, 2022 20:15
@c-ehrlich
Copy link
Member Author

I've left the stop() instead of stopAndPersist() for now.

Reference:
stopAndPersist (old) on the left
stop (new) on the right

stopAndPersist vs stop

can change it back of course

juliusmarminge
juliusmarminge approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@juliusmarminge juliusmarminge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it

@juliusmarminge juliusmarminge merged commit 1cc6735 into next Oct 17, 2022
@juliusmarminge juliusmarminge deleted the fix-spinner branch October 17, 2022 20:32
@github-actions github-actions bot mentioned this pull request Oct 17, 2022
Merged
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
@c-ehrlich
fix: git spinner (t3-oss#621)
bde1d76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusmarminge juliusmarminge juliusmarminge approved these changes

@nexxeln nexxeln Awaiting requested review from nexxeln

@t3dotgg t3dotgg Awaiting requested review from t3dotgg

Assignees
No one assigned
Labels
📌 area: cli Relates to the CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c-ehrlich @juliusmarminge