-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: next 15 #2000
feat: next 15 #2000
Conversation
🦋 Changeset detectedLatest commit: 1e0aa94 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@ronanru is attempting to deploy a commit to the t3-oss Team on Vercel. A member of the Team first needs to authorize it. |
How useful really is this (ts config) considering the cjs limitations? |
I don't like seeing js files in my src folder. With ts next config
|
I tried multiple configurations, everything seems to work. Dev, Build, LSP all work. I get an error for missing env variables. |
Try doing something esm in it, it will crash This works: // app/env.js
import { createEnv } from "@t3-oss/env-nextjs";
import { vercel } from "@t3-oss/env-nextjs/presets"
import { z } from "zod";
console.log(import.meta.filename)
export const env = createEnv({
extends: [vercel()],
server: {
FOO: z.string()
},
experimental__runtimeEnv: {
FOO: "bar"
}
});
// next.config.js
import "./app/env.js"
export default {
/* config options here */
}; Change file extensions to |
oh, ok. I reverted the next config changes. We can add them later when the ESM thing is fixed. |
we could have it like turbo and use jiti to load the ts file ? |
Hey t3-oss/translators! This PR contains changes to your language. Please review the changes ❤️. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some more changes to get it more in line with Next Auth v5 standards.
I did some manual testing but would be nice with some more before merging. Can you look it over again @ronanru and make sure my additions are all good?
Can @t3dotgg @c-ehrlich and @nexxeln please review the code please?? I think it would be useful to have it implemented already |
Just tested your changes, everything looks good @juliusmarminge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM++
✅ Checklist
Changelog
next-auth
to v5 (beta)Closes #1979
Closes #1999
Closes #1812