Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: start-database.sh CONTAINER_NAME update with '.' project name (#1834) #1857

Closed
wants to merge 0 commits into from

Conversation

xelacast
Copy link
Contributor

@xelacast xelacast commented Apr 28, 2024

Closes #1834

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

The dbContainer.ts file in cli/src/installers/dbContainer.ts was updated with a parseNameAndPath function when a projectName of "." was used. This was done with a ternary and destructuring to keep the type safety of the variable.

I had a few options.

  1. I could change the start-database.sh script to check for "." project names and change accordingly
  2. I could change the file that was changing the start-database.sh file
    I decided to go with the last route because it's a single source of truth and can be used for future implementations.

I followed the data flow of projectName and scopedProjectName through and through and couldn't find a solution.
Then I tried a few other things to see If I could make this feel less hacky but to no avail.

Screenshots

[Screenshots]

💯

Copy link

changeset-bot bot commented Apr 28, 2024

⚠️ No Changeset found

Latest commit: 29348b6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 1 unresolved
✅ 1 resolved
May 3, 2024 10:58pm

Copy link

vercel bot commented Apr 28, 2024

@xelacast is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: In ./start-database.sh DB_CONTAINER_NAME should be changed
1 participant