chore: remove duplicate hostname resource attribute (open-telemetry#1581

) Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
t2t2 · Oct 9, 2020 · 83e6af0 · 83e6af0
1 parent e62c481
commit 83e6af0
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 13 deletions.
diff --git a/packages/opentelemetry-resource-detector-aws/src/detectors/AwsEc2Detector.ts b/packages/opentelemetry-resource-detector-aws/src/detectors/AwsEc2Detector.ts
@@ -71,7 +71,6 @@ class AwsEc2Detector implements Detector {
       [HOST_RESOURCE.ID]: instanceId,
       [HOST_RESOURCE.TYPE]: instanceType,
       [HOST_RESOURCE.NAME]: hostname,
-      [HOST_RESOURCE.HOSTNAME]: hostname,
     });
   }
 

diff --git a/packages/opentelemetry-resources/src/constants.ts b/packages/opentelemetry-resources/src/constants.ts
@@ -47,12 +47,6 @@ export const CONTAINER_RESOURCE = {
 
 /** Attributes defining a computing instance (e.g. host). */
 export const HOST_RESOURCE = {
-  /**
-   * Hostname of the host. It contains what the hostname command returns on the
-   * host machine.
-   */
-  HOSTNAME: 'host.hostname',
-
   /**
    * Unique host id. For Cloud this must be the instance_id assigned by the
    * cloud provider

diff --git a/packages/opentelemetry-resources/test/resource-assertions.test.ts b/packages/opentelemetry-resources/test/resource-assertions.test.ts
@@ -89,7 +89,6 @@ describe('assertHostResource', () => {
 
   it('validates optional attributes', () => {
     const resource = new Resource({
-      [HOST_RESOURCE.HOSTNAME]: 'opentelemetry-test-hostname',
       [HOST_RESOURCE.ID]: 'opentelemetry-test-id',
       [HOST_RESOURCE.NAME]: 'opentelemetry-test-name',
       [HOST_RESOURCE.TYPE]: 'n1-standard-1',

diff --git a/packages/opentelemetry-resources/test/util/resource-assertions.ts b/packages/opentelemetry-resources/test/util/resource-assertions.ts
@@ -122,11 +122,6 @@ export const assertHostResource = (
   }
 ) => {
   assertHasOneLabel(HOST_RESOURCE, resource);
-  if (validations.hostName)
-    assert.strictEqual(
-      resource.attributes[HOST_RESOURCE.HOSTNAME],
-      validations.hostName
-    );
   if (validations.id)
     assert.strictEqual(resource.attributes[HOST_RESOURCE.ID], validations.id);
   if (validations.name)