audio/pcm: use host os_timestamp for PLAYBACK to fix reload crash#30
Open
jjohnson wants to merge 1 commit into
Open
audio/pcm: use host os_timestamp for PLAYBACK to fix reload crash#30jjohnson wants to merge 1 commit into
jjohnson wants to merge 1 commit into
Conversation
PLAYBACK used dev_timestamp from the T2 coprocessor clock domain, which drifts from the host's ktime_get_boottime() after module reload. This produced wild position values in aaudio_pcm_pointer, triggering XRUN and a scheduling-while-atomic panic when snd_pcm_do_stop ran from DMA IRQ context. Switch PLAYBACK to os_timestamp (host boottime at message receipt), matching what CAPTURE already does. The mailbox transit delay (~100 microseconds at most) is negligible in a 347 ms ALSA buffer and eliminates the crash entirely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLAYBACK used dev_timestamp from the T2 coprocessor clock domain,
which drifts from the host's ktime_get_boottime() after module reload.
This produced wild position values in aaudio_pcm_pointer, triggering
XRUN and a scheduling-while-atomic panic when snd_pcm_do_stop ran
from DMA IRQ context.
Switch PLAYBACK to os_timestamp (host boottime at message receipt),
matching what CAPTURE already does. The mailbox transit delay (~100
microseconds at most) is negligible in a 347 ms ALSA buffer and
eliminates the crash entirely.