Skip to content

chore: update chain-id#52

Merged
w-woloszyn merged 3 commits into
canaryfrom
chore/chain-id
Feb 28, 2025
Merged

chore: update chain-id#52
w-woloszyn merged 3 commits into
canaryfrom
chore/chain-id

Conversation

@w-woloszyn

@w-woloszyn w-woloszyn commented Feb 25, 2025

Copy link
Copy Markdown
Contributor

New chain-id

Description

We ditch Kurtosis chain-id for a new one

Motivation and Context

We need a unique chain-id, and this one is about the speed of light ;)

How Has This Been Tested?

canary2 machine

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Style (style only changes)
  • Refactor (code that does not add new functionality nor fixes a bug)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I added deployment script (Makefile, docker file etc.)
  • I have updated the documentation accordingly - Docusaurus.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@w-woloszyn w-woloszyn marked this pull request as draft February 25, 2025 01:01
@w-woloszyn w-woloszyn marked this pull request as ready for review February 25, 2025 01:03
@evchip

evchip commented Feb 25, 2025

Copy link
Copy Markdown
Contributor

everyone needs to update the chain ID in their wallet based on this change right? @w-woloszyn

@w-woloszyn

Copy link
Copy Markdown
Contributor Author

everyone needs to update the chain ID in their wallet based on this change right? @w-woloszyn

yes, though metamask will suggest the new one by fetching it from rpc

@evchip

evchip commented Feb 25, 2025

Copy link
Copy Markdown
Contributor

everyone needs to update the chain ID in their wallet based on this change right? @w-woloszyn

yes, though metamask will suggest the new one by fetching it from rpc

Even if the user has already created a network with the old chain ID but the same RPC URL?

kss-t1
kss-t1 previously approved these changes Feb 25, 2025
@kss-t1

kss-t1 commented Feb 25, 2025

Copy link
Copy Markdown
Member

everyone needs to update the chain ID in their wallet based on this change right? @w-woloszyn

yes, though metamask will suggest the new one by fetching it from rpc

Even if the user has already created a network with the old chain ID but the same RPC URL?

I think we should change Chain ID even if that would require users to remove t1 network and recreate it in Metamask.

@evchip

evchip commented Feb 25, 2025

Copy link
Copy Markdown
Contributor

everyone needs to update the chain ID in their wallet based on this change right? @w-woloszyn

yes, though metamask will suggest the new one by fetching it from rpc

Even if the user has already created a network with the old chain ID but the same RPC URL?

I think we should change Chain ID even if that would require users to remove t1 network and recreate it in Metamask.

Agreed, but it's worth flagging 🇵🇱

@evchip evchip left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update T1_DEVNET_CHAIN_ID in T1Constants.sol

Signed-off-by: Wojciech Wołoszyn <w-woloszyn@users.noreply.github.com>
@w-woloszyn w-woloszyn requested a review from evchip February 28, 2025 12:50

@evchip evchip left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! please communicate when the canary env will use this chain ID, as we will need to update it on the front end

@w-woloszyn w-woloszyn merged commit c66505f into canary Feb 28, 2025
@w-woloszyn w-woloszyn deleted the chore/chain-id branch February 28, 2025 20:16
@kss-t1 kss-t1 mentioned this pull request Mar 3, 2025
10 tasks
diego-G pushed a commit that referenced this pull request Mar 20, 2025
Signed-off-by: Wojciech Wołoszyn <w-woloszyn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants