feat: contracts use isProver instead of isValidSigner#44
Merged
Conversation
Contributor
Author
|
I will merge only when getting approve both here and on the postman side. |
Contributor
|
Looks like we'll need to set the |
diego-G
suggested changes
Feb 18, 2025
diego-G
previously approved these changes
Feb 18, 2025
Contributor
Author
diego-G
approved these changes
Feb 18, 2025
evchip
reviewed
Feb 18, 2025
diego-G
added a commit
that referenced
this pull request
Mar 20, 2025
Co-authored-by: Diego <diego.gm@pm.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to use Scroll's isProver, since it is ready to use
Description
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: