Skip to content

Feature/xyield erc 4626 withdraw#165

Merged
evchip merged 47 commits into
canaryfrom
feature/xyield-erc-4626-withdraw
Aug 24, 2025
Merged

Feature/xyield erc 4626 withdraw#165
evchip merged 47 commits into
canaryfrom
feature/xyield-erc-4626-withdraw

Conversation

@evchip

@evchip evchip commented Aug 20, 2025

Copy link
Copy Markdown
Contributor

Description

xYieldVault.sol

  • replace updateTotals params with struct
  • add withdrawFrom method for remote withdrawals
  • change updateBalances implementation to support burning or minting tokens
  • add fork test for remoteWithdraw method

Motivation and Context

Facilitate same chain withdrawals. Remote withdrawals are partially implemented, but will need bridging capabilities to be fully functional. We are parking this for the time being.

How Has This Been Tested?

Added fork and unit tests

Types of changes (remove all unchecked types)

  • New feature (non-breaking change which adds functionality)

Checklist:

  • If my change requires a change to the documentation, I have updated the documentation accordingly, and in either case, have checked this box to attest to my assessment of this requirement with regard to my change.
  • If my change requires additions or updates to any deployment scripts to ensure that the protocol is functional (Makefile, Dockerfile, Forge Script, etc.), I have made these changes, and in either case, have checked this box to attest to my assessment of this requirement with regard to my change.
  • If my change requires additional test coverage, I have created those tests accordingly, and in either case, have checked this box to attest to my assessment of this requirement with regard to my change.

evchip added 30 commits July 31, 2025 20:07
establishing simple deposits and withdrawals; add unimplemented functions as todos
bad dependency path on ethereum vault connector
instead of calling yieldProtocol.totalAssets we need to call yieldProtocol.convertToAssets
deposit, withdraw, and interest accrual
to prevent compile issues with incompatible solc versions
add withdrawFrom method for remote withdrawals; change updateBalances implementation to support
burning or minting tokens; add fork test for remoteWithdraw method
@evchip evchip marked this pull request as ready for review August 21, 2025 05:32
@evchip evchip requested a review from aharvet August 21, 2025 05:32
@evchip evchip self-assigned this Aug 21, 2025
Comment thread contracts/src/xYield/xYieldVault.sol
Comment thread contracts/src/xYield/xYieldVault.sol Outdated
Comment thread contracts/src/xYield/xYieldVault.sol Outdated
Comment thread contracts/src/xYield/xYieldVault.sol
@evchip evchip requested a review from aharvet August 22, 2025 08:40
Base automatically changed from feature/xyield-erc-4626 to canary August 22, 2025 15:24

@aharvet aharvet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evchip evchip merged commit b4061cd into canary Aug 24, 2025
4 checks passed
@evchip evchip deleted the feature/xyield-erc-4626-withdraw branch August 24, 2025 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants