Feature/xyield erc 4626 withdraw#165
Merged
Merged
Conversation
establishing simple deposits and withdrawals; add unimplemented functions as todos
bad dependency path on ethereum vault connector
instead of calling yieldProtocol.totalAssets we need to call yieldProtocol.convertToAssets
deposit, withdraw, and interest accrual
to prevent compile issues with incompatible solc versions
add withdrawFrom method for remote withdrawals; change updateBalances implementation to support burning or minting tokens; add fork test for remoteWithdraw method
in order to track remote chain
aharvet
suggested changes
Aug 21, 2025
aharvet
reviewed
Aug 21, 2025
total assets should be based on xYield's balance of share tokens; change erc20 transfer calls to safeTransfer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
xYieldVault.solMotivation and Context
Facilitate same chain withdrawals. Remote withdrawals are partially implemented, but will need bridging capabilities to be fully functional. We are parking this for the time being.
How Has This Been Tested?
Added fork and unit tests
Types of changes (remove all unchecked types)
Checklist: