Skip to content

Feat/sealed bid auction/auction on intent open#147

Merged
kss-t1 merged 28 commits into
canaryfrom
feat/sealed-bid-auction/auction-on-intent-open
Aug 4, 2025
Merged

Feat/sealed bid auction/auction on intent open#147
kss-t1 merged 28 commits into
canaryfrom
feat/sealed-bid-auction/auction-on-intent-open

Conversation

@kss-t1

@kss-t1 kss-t1 commented Jul 30, 2025

Copy link
Copy Markdown
Member

Description

Next part of Sealed Bid implementation:

  • observing Intent opened onchain
  • running auction for that Intent
  • notifying winning Solver

Motivation and Context

How Has This Been Tested?

Types of changes (remove all unchecked types)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Style (style only changes)
  • Docs
  • Refactor (code that does not add new functionality nor fixes a bug)

Checklist:

  • If my change requires a change to the documentation, I have updated the documentation accordingly, and in either case, have checked this box to attest to my assessment of this requirement with regard to my change.
  • If my change requires additions or updates to any deployment scripts to ensure that the protocol is functional (Makefile, Dockerfile, Forge Script, etc.), I have made these changes, and in either case, have checked this box to attest to my assessment of this requirement with regard to my change.
  • If my change requires additional test coverage, I have created those tests accordingly, and in either case, have checked this box to attest to my assessment of this requirement with regard to my change.

@kss-t1 kss-t1 requested a review from aharvet July 30, 2025 01:33
aharvet
aharvet previously approved these changes Jul 30, 2025

@aharvet aharvet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two design notes plus one not to returned data.
All good otherwise.

Comment thread tee-apps/sealed-bid-auction/index.ts Outdated
Comment thread tee-apps/sealed-bid-auction/src/blockchain/ArbitrumSepoliaIntentObserver.ts Outdated
Comment thread tee-apps/sealed-bid-auction/src/api/types.ts Outdated
Comment thread tee-apps/sealed-bid-auction/src/api/types.ts Outdated
Base automatically changed from feat/sealed-bid-auction/price-stream to canary July 31, 2025 13:31
@kss-t1 kss-t1 dismissed aharvet’s stale review July 31, 2025 13:31

The base branch was changed.

@kss-t1 kss-t1 requested a review from aharvet July 31, 2025 15:27
@kss-t1 kss-t1 requested a review from w-woloszyn August 1, 2025 12:42
w-woloszyn
w-woloszyn previously approved these changes Aug 4, 2025
Comment thread tee-apps/sealed-bid-auction/src/blockchain/ViemIntentObserver.ts
@kss-t1 kss-t1 requested a review from w-woloszyn August 4, 2025 14:19

@w-woloszyn w-woloszyn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kss-t1 kss-t1 merged commit ca395d5 into canary Aug 4, 2025
4 checks passed
@kss-t1 kss-t1 deleted the feat/sealed-bid-auction/auction-on-intent-open branch August 4, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants