Skip to content

feat: remove gasLimit and payable requirement from T1XChainReader#132

Merged
w-woloszyn merged 1 commit into
canaryfrom
feat/T1XChainReader-remove-gas-limit-and-payable-requirement
Jul 1, 2025
Merged

feat: remove gasLimit and payable requirement from T1XChainReader#132
w-woloszyn merged 1 commit into
canaryfrom
feat/T1XChainReader-remove-gas-limit-and-payable-requirement

Conversation

@w-woloszyn

Copy link
Copy Markdown
Contributor

Removes gasLimits, payable, and introduces upgradability back to T1XChainReader

Description

  • Restored owner functionality and simplified cross-chain read events in T1XChainReader by removing the gas limit parameter and ETH checks
  • Updated T1ERC7683 to match the new reader interface, eliminating the gas limit argument in verifySettlement
  • Adjusted tests to use the streamlined settlement verification call without a gas limit parameter
  • Modified settlement scripts accordingly, ensuring they invoke verifySettlement with only destination and orderId

Motivation and Context

Addresses post merge comments from #122

How Has This Been Tested?

unit tests

Types of changes (remove all unchecked types)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactor (code that does not add new functionality nor fixes a bug)

Checklist:

  • If my change requires a change to the documentation, I have updated the documentation accordingly, and in either case, have checked this box to attest to my assessment of this requirement with regard to my change.
  • If my change requires additions or updates to any deployment scripts to ensure that the protocol is functional (Makefile, Dockerfile, Forge Script, etc.), I have made these changes, and in either case, have checked this box to attest to my assessment of this requirement with regard to my change.
  • If my change requires additional test coverage, I have created those tests accordingly, and in either case, have checked this box to attest to my assessment of this requirement with regard to my change.

@w-woloszyn w-woloszyn requested a review from evchip July 1, 2025 15:55
@w-woloszyn w-woloszyn self-assigned this Jul 1, 2025
@evchip

evchip commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

should have mentioned that we will also need to change Eco's T1Prover contract to work with this new interface. cc @w-woloszyn

@evchip evchip left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

@w-woloszyn w-woloszyn merged commit 086945d into canary Jul 1, 2025
4 checks passed
@w-woloszyn w-woloszyn deleted the feat/T1XChainReader-remove-gas-limit-and-payable-requirement branch July 1, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants