Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create and push the v1.3.0 tag #30

Closed
Stonelinks opened this issue Jan 22, 2014 · 4 comments
Closed

create and push the v1.3.0 tag #30

Stonelinks opened this issue Jan 22, 2014 · 4 comments

Comments

@Stonelinks
Copy link

Hey t0m,

Just an FYI, people who use package managers like bower or any other package/dependency manager that looks for specific git tags for every release are missing out on the 1.3.0 release on the bootstrap3 branch. There is no tag in @fk's repo either.

I ended up forking the repo and creating the tag from t0m's 1.3.0 commit on the bootstrap3 branch. Just thought I'd let you two know.

Thanks for your contribution!

@nickl-
Copy link
Collaborator

nickl- commented Jan 22, 2014

@Stonelinks you can also point to a branch or commit tag on GitHub repos with bower

Something on the lines of:

$ bower install t0m/select2-bootstrap-css#bootstrap3

Will attach you to the branch and always install the latest revision on that branch (not ideal)

Without a tag you can still work against a specific commit tag (which will remain constant)

$ bower install t0m/select2-bootstrap-css#cd5014bef8ea2692ba6e56219ba7117472f911ad

FYI fk's repo is missing a lot of changes that happened on the master branch and that is why we needed to rebase his changes onto the latest changes on master.

On my repo the 1.3.0 tag is applied after rebased against master.

$ bower install nickl-/select2-bootstrap-css#1.3.0

At the time of this writing all three install commands will produce exactly the same result but only the last two will always remain the same. Confused yet? =)

nJoy!

P.S I will apply the tag for you post haste...

@nickl- nickl- closed this as completed Jan 22, 2014
@Stonelinks
Copy link
Author

Yeah having all the versions of my dependencies persist to my bower.json is important for me. Guess I haven't kept up with bower development though. For the longest time I thought you couldn't point bower to specific commits, and that was by design. I believe the bower authors wanted everybody to follow semantic versioning (which is a good idea IMHO, but not every library maintainer does this).

Anyways, thanks for the info and for pushing the tag! I'm going to go delete a bunch of submodules and forks now 👍

@fk
Copy link
Collaborator

fk commented Jan 22, 2014

Thanks for everything @nickl-!

@nickl-
Copy link
Collaborator

nickl- commented Jan 24, 2014

@fk glad I can help... when I remember that is.

It usually only dawns once I spot the close button, which I find odd at first and it slowly sinks in.

morungos added a commit to oicr-ibc/heliotrope that referenced this issue Aug 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants