Bootstrap 3 Support

[ecabuk]

Hi,

Do you planning to support bootstrap 3?

Thanks

[michaek]

Certainly, but I haven't looked into it yet.

[jcspader]

I'm also awaiting

[cgardner]

I am also interested in Bootstrap3 support

[michaek]

Can we avoid doing +1 style responses to this? Thanks!

[fk]

We recently began a project using Twitter Bootstrap 3 RC1 in which we also make (albeit very basic) use of select2 to extend the functionality of a bunch of multi-value select-elements.
While trying to adjust select2's default styles to match Bootstrap I stumbled upon this fine project and am happy to report that I didn't find any major problems concerning Bootstrap 3 – just the line-height for select2-container-multi .select2-choices .select2-search-field was causing problems (in Google Chrome only as far as I can remember).

Being at home with a bit of a cold right now I thought I'll give a full update a shot but I ran into several problems while trying to support all use cases featured on the demo pages – namely the "Select2 custom data load" example and the sizing demonstrations – but the basic stuff is mostly done.

If you want to check out what I got so far, head over to https://github.com/fk/select2-bootstrap-css.
To easily review my changes, I did the main work in the "gh-pages"-branch: https://github.com/fk/select2-bootstrap-css/commits/gh-pages – and here's the demonstration: http://fk.github.io/select2-bootstrap-css/

[rohitdev]

@fk did not work for me.All the componets are misaligned

[fk]

@rohitdev The repository was really messy for the last 1,5 days – I somehow missed looking into what actually goes on in the master-branch and started hacking away in the gh-pages-branch, so if you tried to use the CSS from master it most probably wasn't up-to-date. Sorry for that.

Please give the demos at http://fk.github.io/select2-bootstrap-css/ another shot; this is still a work in progress, but it should be usable by now. Will do my best to update the demos with some documentation the next few days.

[michaek]

One reason that I haven't taken on the changes necessary to support Bootstrap 3 is that I don't want to sacrifice support for Bootstrap 2.3. There are plenty of good reasons to choose not to move to Bootstrap 3 from Bootstrap 2.

If we can maintain support for Bootstrap 2 along with visibility for Bootstrap 2 in the demos, I think the changes from @fk are definitely worth considering. However, considering the number of commits and amount noise in that repo, I don't think a pull request without some aggressive rebasing would make sense.

[fk]

@michaek Thanks for the nice words! You're definitely right about the noise – when I started hacking away in the gh-pages branch, I lay in bed with 39° temperature and this shows in structure, underestimating the job and procrastinating. As stated in my previous comment I initially didn't even took a look into the master-branch – a big mistake. If I only had taken a moment to understand how the master-branch works, I'd at least been working in a feature-branch … surely not one of my finer git(hub)-moments. :/

That said, I've been wanting to get back to you and @t0m regarding my work for Bootstrap 3 – I'd be more than happy to contribute back!

I've been working on integrating Bootstrap 3's control sizing and validation states today and am hoping to fix things for IE8 in the next 24 hours.

[michaek]

Let me know when you're happy with what you've got, I'll take a look, and we can work on getting your changes into this project.

[lohmeyer]

@michaek

Great news! Coming back soon ... ;)

[fk]

@michaek I might be a few hours late, but I'm quite happy with what I got so far: All major browsers (tested in latest Chrome, Safari, Firefox, Opera (Mac) and IE8-IE10), Select v.3.3.2, backporting Sass to LESS and basic use cases are covered and only a few bugs remain.

What do you think about the open stuff – are these showstoppers regarding contributing back/releasing?

I will definitely take a look at these in the future (and I'd also like to improve the inline CSS documentation a bit, among other things) but as I'll be quite occupied with catching up at work for the next few days maybe it's best to run with what I got so far (my English su**s today, I hope I can get my point across).

[SharpNoiZy]

@fk
I tried your bootstrap 3 branch and it looks already very good!
But I found one litte issue.
On a single select scenario if I click on the select and the popup is shown and I don't choose any item, instead I click somewhere on the page the blue highlight border stays around the input field.

Kind regards

[lohmeyer]

@SharpNoiZy

true, the same happens for me. But I can live with it ...

[fk]

@SharpNoiZy @lohmeyer Yep, I also noticed that – seems it's a bug introduced with select 3.4.0 which according to this issue should be fixed in select2-master.

However, the demo at http://ivaynberg.github.io/select2/select2-latest.html#basics still shows the faulty behavior (.select2-container-active not being removed) – if I'm not mistaken; I only took a very quick look at this. I'll have access to my dev box at the end of the coming week and will look into this again.