fix: Update position calculation test expectations #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
t-ho
commented
Jul 29, 2025
t-ho
commented
- Fix failing position calculation tests to match current component implementation
- Update test expectations from nested calc format to simplified format
- Disable Angular CLI analytics in angular.json
- All 133 tests now pass with 100% coverage
- Fix failing position calculation tests to match current component implementation - Update test expectations from nested calc format to simplified format - Disable Angular CLI analytics in angular.json - All 133 tests now pass with 100% coverage
- Update Actions to latest versions (checkout@v4, setup-node@v4, codecov@v4) - Update Node.js versions to 16.x, 18.x, 20.x (remove deprecated 14.x) - Add Chrome setup for headless testing - Use npm ci and built-in caching for better performance - Use npm run scripts instead of npx commands - Make codecov upload optional to prevent CI failures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.