[#62] No need to create pitest configuration manually

szpak · Apr 27, 2020 · 3ad30e3 · 3ad30e3
1 parent 4e9c111
commit 3ad30e3
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 6 deletions.
diff --git a/README.md b/README.md
@@ -254,7 +254,6 @@ repositories {
     mavenCentral()
 }
 
-configurations.create('pitest')
 dependencies {
    pitest 'org.pitest:pitest-junit5-plugin:0.12'
 }

diff --git a/config/codenarc/codenarc.xml b/config/codenarc/codenarc.xml
@@ -36,6 +36,7 @@
     <ruleset-ref path='rulesets/logging.xml' />
     <ruleset-ref path='rulesets/naming.xml'>
         <exclude name="MethodName" />
+        <exclude name="FactoryMethodName" />
     </ruleset-ref>
     <ruleset-ref path='rulesets/serialization.xml' />
     <ruleset-ref path='rulesets/unnecessary.xml'>

diff --git a/...t/groovy/info/solidsoft/gradle/pitest/functional/PitestPluginGeneralFunctionalSpec.groovy b/...t/groovy/info/solidsoft/gradle/pitest/functional/PitestPluginGeneralFunctionalSpec.groovy
@@ -20,7 +20,6 @@ class PitestPluginGeneralFunctionalSpec extends AbstractPitestFunctionalSpec {
                 repositories {
                     maven { url "https://dl.bintray.com/szpak/pitest-plugins/" }
                 }
-                configurations.create("pitest")
                 dependencies {
                     pitest 'org.pitest.plugins:pitest-plugin-configuration-reporter-plugin:0.0.2'
                 }

diff --git a/src/funcTest/resources/testProjects/junit5kotlin/build.gradle b/src/funcTest/resources/testProjects/junit5kotlin/build.gradle
@@ -25,8 +25,6 @@ repositories {
     mavenCentral()
 }
 
-configurations.create("pitest")
-
 dependencies {
     implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk8:$kotlin_version"
     testImplementation "org.junit.jupiter:junit-jupiter-api:$junit5Version"

diff --git a/src/main/groovy/info/solidsoft/gradle/pitest/PitestPlugin.groovy b/src/main/groovy/info/solidsoft/gradle/pitest/PitestPlugin.groovy
@@ -75,6 +75,8 @@ class PitestPlugin implements Plugin<Project> {
     void apply(Project project) {
         this.project = project
         gradleVersionEnforcer.failBuildWithMeaningfulErrorIfAppliedOnTooOldGradleVersion(project)
+        Configuration pitestConfiguration = createConfiguration()
+
         project.plugins.withType(JavaPlugin).configureEach {
             setupExtensionWithDefaults()
             project.tasks.register(PITEST_TASK_NAME, PitestTask) { t ->
@@ -83,12 +85,12 @@ class PitestPlugin implements Plugin<Project> {
                 configureTaskDefault(t)
                 t.dependsOn(calculateTasksToDependOn())
                 t.shouldRunAfter(project.tasks.named(TEST_TASK_NAME))
-                addPitDependencies(configuration())
+                addPitDependencies(pitestConfiguration)
             }
         }
     }
 
-    private Configuration configuration() {
+    private Configuration createConfiguration() {
         return project.configurations.maybeCreate(PITEST_CONFIGURATION_NAME).with { configuration ->
             visible = false
             description = "The PIT libraries to be used for this project."