Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite main logic #31

Merged
merged 22 commits into from
May 9, 2020
Merged

Rewrite main logic #31

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
4752733
Rewrite main logic
szmarczak May 8, 2020
7376a0f
Support dns.ALL flag
szmarczak May 8, 2020
f72c309
fixes
szmarczak May 9, 2020
88f3315
typo
szmarczak May 9, 2020
353da54
throw on cache.set() error
szmarczak May 9, 2020
f97735f
Remove moot tests
szmarczak May 9, 2020
4b760de
fix linting
szmarczak May 9, 2020
78622c4
fixes
szmarczak May 9, 2020
3727364
fixes
szmarczak May 9, 2020
e23a116
make tests pass
szmarczak May 9, 2020
c59be4e
Support custom iterable maps
szmarczak May 9, 2020
f8dd106
Test ALL flag
szmarczak May 9, 2020
664c2e9
test fallback
szmarczak May 9, 2020
fe0aa69
Add another test for V4MAPPED
szmarczak May 9, 2020
4881205
Test other errors
szmarczak May 9, 2020
f509664
test full-featured external cache
szmarczak May 9, 2020
3b86f1b
Test fallback #2
szmarczak May 9, 2020
5b792e6
make tests pass on Node.js < 14
szmarczak May 9, 2020
fe297cb
wtf
szmarczak May 9, 2020
c27cc5f
fixes
szmarczak May 9, 2020
4c0964d
Fix docs
szmarczak May 9, 2020
4fbcd75
no because
szmarczak May 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test fallback
  • Loading branch information
@szmarczak
szmarczak committed May 9, 2020
commit 664c2e9a10d73181ff28484ff09358741f04e5a7
8 changes: 8 additions & 0 deletions tests/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -768,6 +768,14 @@ test.serial('fallback works', async t => {
});
});

test('fallback can be turned off', async t => {
const cacheable = new CacheableLookup({resolver, fallbackDuration: 0});

await t.throwsAsync(cacheable.lookupAsync('osHostname', {all: true}), {
message: 'cacheableLookup ENOTFOUND osHostname'
});
});

test('errors are cached', async t => {
const cacheable = new CacheableLookup({resolver, errorTtl: 0.1});

Expand Down