Fix typings

szmarczak · Aug 20, 2021 · 06fd8fc · 06fd8fc
1 parent 5960e1d
commit 06fd8fc
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/index.d.ts b/index.d.ts
@@ -99,10 +99,10 @@ export default class CacheableLookup {
 	/**
 	 * @see https://nodejs.org/api/dns.html#dns_dns_lookup_hostname_options_callback
 	 */
-	lookup(hostname: string, family: IPFamily, callback: (error: NodeJS.ErrnoException, address: string, family: IPFamily) => void): void;
-	lookup(hostname: string, callback: (error: NodeJS.ErrnoException, address: string, family: IPFamily) => void): void;
-	lookup(hostname: string, options: LookupOptions & {all: true}, callback: (error: NodeJS.ErrnoException, result: ReadonlyArray<EntryObject>) => void): void;
-	lookup(hostname: string, options: LookupOptions, callback: (error: NodeJS.ErrnoException, address: string, family: IPFamily) => void): void;
+	lookup(hostname: string, family: IPFamily, callback: (error: NodeJS.ErrnoException | null, address: string, family: IPFamily) => void): void;
+	lookup(hostname: string, callback: (error: NodeJS.ErrnoException | null, address: string, family: IPFamily) => void): void;
+	lookup(hostname: string, options: LookupOptions & {all: true}, callback: (error: NodeJS.ErrnoException | null, result: ReadonlyArray<EntryObject>) => void): void;
+	lookup(hostname: string, options: LookupOptions, callback: (error: NodeJS.ErrnoException | null, address: string, family: IPFamily) => void): void;
 	/**
 	 * The asynchronous version of `dns.lookup(…)`.
 	 */

diff --git a/index.test-d.ts b/index.test-d.ts
@@ -37,22 +37,25 @@ import CacheableLookup, {EntryObject} from '.';
 	expectType<ReadonlyArray<EntryObject>>(await cacheable.lookupAsync('localhost', {all: true}));
 
 	cacheable.lookup('localhost', 6, (error, address, family) => {
-		expectType<NodeJS.ErrnoException>(error);
+		expectType<NodeJS.ErrnoException | null>(error);
 		expectType<string>(address);
 		expectType<4 | 6>(family);
 	});
 
 	cacheable.lookup('localhost', {all: false}, (error, address, family) => {
-		expectType<NodeJS.ErrnoException>(error);
+		expectType<NodeJS.ErrnoException | null>(error);
 		expectType<string>(address);
 		expectType<4 | 6>(family);
 	});
 
 	cacheable.lookup('localhost', {all: true}, (error, results) => {
-		expectType<NodeJS.ErrnoException>(error);
+		expectType<NodeJS.ErrnoException | null>(error);
 		expectType<ReadonlyArray<EntryObject>>(results);
 	});
 
+	// @types/node has invalid typings :(
+	// expectType<typeof cacheable.lookup>(lookup);
+
 	expectType<ReadonlyArray<EntryObject>>(await cacheable.query('localhost'));
 	expectType<ReadonlyArray<EntryObject>>(await cacheable.queryAndCache('localhost'));