MenuGroup shouldn't render a div

[mgtitimoli]

Hi there!

First of all, I would like to thank you for the amazing work you did with react-menu, it works fantastic!

It's not critical, but I opened this issue as I've just noticed that the MenuGroup renders a div which is not semantically correct and it's being rendered inside an ul.

Would it make sense to render it using a li with an ul inside instead?

Thanks!

[szhsin]

Thanks for reporting this issue.

Yes, this does appear to be a semantic violation. MenuGroup is intended purely as a presentation layer for grouping its child items, and rendering a div directly inside a ul isn’t ideal.

I couldn’t find a clear accessibility guideline that explicitly covers this case, but it makes sense to follow the pattern used by MenuRadioGroup, e.g.

<li role="none">
  <ul role="group">
    {/* menu items */}
  </ul>
</li>

I’ll fix this in the next version.