This repository has been archived by the owner on Feb 23, 2019. It is now read-only.
Fix for Role Removal from $current_user #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the $current_user is logged in (meaning, they have a user id > 0) they're always guaranteed to have a designated "role". With that in mind one can do away with the ill advised array_shift() function call, which was unintentionally stripping the active $current_user's role, and simply just lookup the 1st item in its "roles" array.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the $current_user is logged in (meaning, they have a user id > 0) they're always guaranteed to have a designated "role". With that in mind one can do away with the ill-advised array_shift() function call, which was unintentionally stripping the active $current_user's role globally, and simply just lookup the 1st element in its "roles" array. #42