Skip to content

Conversation

dingo-d
Copy link
Contributor

@dingo-d dingo-d commented Sep 20, 2020

The ones that have exit() calls in them.

Fixes #22

I'm not sure if the functions from the utils.php be included as well. Those are utility functions, not sure if they are used in userland code, or just for internal WP-CLI purposes.

The ones that have exit() calls in them.
Copy link
Owner

@szepeviktor szepeviktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR.

Please remove those two.

@dingo-d
Copy link
Contributor Author

dingo-d commented Sep 21, 2020

@szepeviktor Thanks for the clarification, wasn't sure if any command should be added. I've removed those two 👍

@szepeviktor
Copy link
Owner

Thank you.

@szepeviktor szepeviktor merged commit 604376f into szepeviktor:master Sep 21, 2020
@szepeviktor
Copy link
Owner

https://github.com/szepeviktor/phpstan-wordpress/releases/tag/v0.6.4 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Early return not recognized in the case of \WP_CLI::error
2 participants