Skip to content

Commit

Permalink
Typo fixes in viz.py and CONTRIBUTING.md (apache#5432)
Browse files Browse the repository at this point in the history
  • Loading branch information
visshaljagtap authored and timifasubaa committed Jul 19, 2018
1 parent 99ce7b7 commit 6441f69
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -493,7 +493,7 @@ https://github.com/apache/incubator-superset/pull/3013
In the future we'll start publishing release candidates for minor releases
only, but typically not for micro release.
The process will be similar to the process described above, expect the
tags will be formated `0.25.0rc1`, `0.25.0rc2`, ..., until consensus
tags will be formatted `0.25.0rc1`, `0.25.0rc2`, ..., until consensus
is reached.

We should also have a Github PR label process to target the proper
Expand Down
8 changes: 4 additions & 4 deletions superset/viz.py
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ def __init__(self, datasource, form_data, force=False):
self.force = force

# Keeping track of whether some data came from cache
# this is useful to trigerr the <CachedLabel /> when
# this is useful to trigger the <CachedLabel /> when
# in the cases where visualization have many queries
# (FilterBox for instance)
self._some_from_cache = False
Expand Down Expand Up @@ -129,7 +129,7 @@ def handle_js_int_overflow(data):
return data

def run_extra_queries(self):
"""Lyfecycle method to use when more than one query is needed
"""Lifecycle method to use when more than one query is needed
In rare-ish cases, a visualization may need to execute multiple
queries. That is the case for FilterBox or for time comparison
Expand All @@ -156,7 +156,7 @@ def handle_nulls(self, df):
df = df.fillna(fillna)

def get_fillna_for_col(self, col):
"""Returns the value for use as filler for a specific Column.type"""
"""Returns the value to use as filler for a specific Column.type"""
if col:
if col.is_string:
return ' NULL'
Expand Down Expand Up @@ -323,7 +323,7 @@ def cache_key(self, query_obj):
We remove datetime bounds that are hard values,
and replace them with the use-provided inputs to bounds, which
may we time-relative (as in "5 days ago" or "now").
may be time-relative (as in "5 days ago" or "now").
"""
cache_dict = copy.copy(query_obj)

Expand Down

0 comments on commit 6441f69

Please sign in to comment.