Skip to content

Commit

Permalink
fix: dashboard export raises schema issues (apache#10060)
Browse files Browse the repository at this point in the history
* fix: dashboard export raises schema issues

* Fix isort
  • Loading branch information
mistercrunch authored Jun 16, 2020
1 parent 98ab95e commit 280ade8
Show file tree
Hide file tree
Showing 8 changed files with 8 additions and 9 deletions.
2 changes: 1 addition & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ combine_as_imports = true
include_trailing_comma = true
line_length = 88
known_first_party = superset
known_third_party =alembic,apispec,backoff,bleach,cachelib,celery,click,colorama,contextlib2,croniter,cryptography,dataclasses,dateutil,flask,flask_appbuilder,flask_babel,flask_caching,flask_compress,flask_login,flask_migrate,flask_sqlalchemy,flask_talisman,flask_testing,flask_wtf,geohash,geopy,humanize,isodate,jinja2,markdown,markupsafe,marshmallow,msgpack,numpy,pandas,parsedatetime,pathlib2,polyline,prison,pyarrow,pyhive,pytz,retry,selenium,setuptools,simplejson,sphinx_rtd_theme,sqlalchemy,sqlalchemy_utils,sqlparse,werkzeug,wtforms,wtforms_json,yaml
known_third_party =alembic,apispec,backoff,bleach,cachelib,celery,click,colorama,contextlib2,croniter,cryptography,dateutil,flask,flask_appbuilder,flask_babel,flask_caching,flask_compress,flask_login,flask_migrate,flask_sqlalchemy,flask_talisman,flask_testing,flask_wtf,geohash,geopy,humanize,isodate,jinja2,markdown,markupsafe,marshmallow,msgpack,numpy,pandas,parsedatetime,pathlib2,polyline,prison,pyarrow,pyhive,pytz,retry,selenium,setuptools,simplejson,sphinx_rtd_theme,sqlalchemy,sqlalchemy_utils,sqlparse,werkzeug,wtforms,wtforms_json,yaml
multi_line_output = 3
order_by_type = false

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ class DashboardList extends React.PureComponent<Props, State> {
handleBulkDashboardExport = (dashboards: Dashboard[]) => {
return window.location.assign(
`/api/v1/dashboard/export/?q=${rison.encode(
dashboards.map(({ id }) => id).join(','),
dashboards.map(({ id }) => id),
)}`,
);
};
Expand Down
2 changes: 1 addition & 1 deletion superset/db_engine_specs/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
# specific language governing permissions and limitations
# under the License.
# pylint: disable=unused-argument
import dataclasses
import hashlib
import json
import logging
Expand All @@ -33,7 +34,6 @@
Union,
)

import dataclasses
import pandas as pd
import sqlparse
from flask import g
Expand Down
3 changes: 1 addition & 2 deletions superset/errors.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,10 @@
# specific language governing permissions and limitations
# under the License.
# pylint: disable=too-few-public-methods,invalid-name
from dataclasses import dataclass
from enum import Enum
from typing import Any, Dict, Optional

from dataclasses import dataclass


class SupersetErrorType(str, Enum):
"""
Expand Down
2 changes: 1 addition & 1 deletion superset/sql_parse.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@
# specific language governing permissions and limitations
# under the License.
import logging
from dataclasses import dataclass
from typing import List, Optional, Set
from urllib import parse

import sqlparse
from dataclasses import dataclass
from sqlparse.sql import Identifier, IdentifierList, remove_quotes, Token, TokenList
from sqlparse.tokens import Keyword, Name, Punctuation, String, Whitespace
from sqlparse.utils import imt
Expand Down
2 changes: 1 addition & 1 deletion superset/views/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,13 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
import dataclasses
import functools
import logging
import traceback
from datetime import datetime
from typing import Any, Callable, cast, Dict, List, Optional, TYPE_CHECKING, Union

import dataclasses
import simplejson as json
import yaml
from flask import abort, flash, g, get_flashed_messages, redirect, Response, session
Expand Down
2 changes: 1 addition & 1 deletion superset/viz.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
Superset can render.
"""
import copy
import dataclasses
import hashlib
import inspect
import logging
Expand All @@ -33,7 +34,6 @@
from itertools import product
from typing import Any, cast, Dict, List, Optional, Set, Tuple, TYPE_CHECKING, Union

import dataclasses
import geohash
import numpy as np
import pandas as pd
Expand Down
2 changes: 1 addition & 1 deletion superset/viz_sip38.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
"""
# mypy: ignore-errors
import copy
import dataclasses
import hashlib
import inspect
import logging
Expand All @@ -34,7 +35,6 @@
from itertools import product
from typing import Any, Dict, List, Optional, Set, Tuple, TYPE_CHECKING

import dataclasses
import geohash
import numpy as np
import pandas as pd
Expand Down

0 comments on commit 280ade8

Please sign in to comment.