Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds support for sitelinks #3

Merged
merged 3 commits into from
Nov 10, 2023
Merged

adds support for sitelinks #3

merged 3 commits into from
Nov 10, 2023

Conversation

lenalebt
Copy link
Contributor

@lenalebt lenalebt commented Nov 8, 2023

This is my first rust PR, so please be patient if I forgot something 😅 . It's currently parsing a whole wikidata dump locally. So far ~75GiB (4.5 million entries) without an error.

P1082 parses fine with the most recent master, it was the released 0.3.0 that apparently had troubles with it.

Closes #2

Copy link
Owner

@syvb syvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Just a few minor nits.

Cargo.toml Outdated Show resolved Hide resolved
src/entity.rs Outdated Show resolved Hide resolved
Copy link
Owner

@syvb syvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I just pushed a commit to run cargo fmt for style consistency.

I'll release 0.3.1 shortly.

@syvb syvb merged commit 497ddf9 into syvb:master Nov 10, 2023
@syvb
Copy link
Owner

syvb commented Nov 10, 2023

0.3.1 is now released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Access to sitelinks & parsing P1082
2 participants