- 
                Notifications
    You must be signed in to change notification settings 
- Fork 80
Develop the Newcomers Page First Timers Issue section #263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop the Newcomers Page First Timers Issue section #263
Conversation
| When I click on a newcomer issue, then I just see a blank area in the iframe. | 
| @bethanyr It works properly when opened in a new tab, but yes, it cannot open the link within the iframe and gives this error:  | 
| @BaaniLeen - now there's conflicts in this PR | 
| @bethanyr Resolved the merge conflict :) | 
| There needs to be some indication that it needs to be opened in a new page. | 
| We believe in inclusivity, diversity, and transparency. We value open source citizenship and collaborative involvement. | ||
| </p> | ||
| </div> | ||
| <div class="row justify-content-center mb-3"> | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought you had a previous PR that removed the map from the newcomer's page? Or was it a different page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Before it got merged, I created this branch and started working on this PR. So will have to manually resolve these merge conflicts perhaps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There aren't merge conflicts showing, so when this branch gets merged I think it will re-add the map into the project. You should just go ahead and delete the map out of this code again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh okay. Sure. Doing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bethanyr Done. :)
| <!-- Peace Corps Projects Note--> | ||
| <div class="row text-center"> | ||
| <h1 class="mx-auto mt-5 mb-5">Sysbot</h1> | ||
| <iframe class="iframe-style" src="https://publiclab.github.io/community-toolbox/examples/embed.html#o=systers&r=sysbot"></iframe> | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you planning to only show first-timer issues or all issues for a repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am planning to show first-timers-only issues for all repos, but since right now, none of them have the "first-timers-only" label(other than systers.github.io) but rather have the "First Timers Only" tag, with the spaces, which I did try to work around with using %20 instead of spaces, but did not work. So, I have requested May that we introduce first-timers-only labels, if possible in all the repos, was waiting to discuss with all of you in the All teams meeting today.
Thus, since no issues exist current for the "first-timers-only" label, so in order to show a proper demo, I have not mentioned the label tag yet in the URL.
What are your views about it? Shall I mention the "first-timers-only" label?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine for the demo.
…aaniLeen/systers.github.io into AddingFirstTimersIssuesSection
| I don't think we decided on a solution to the empty iframe in the meeting. Is there a way to do it other than iframes? | 
| @ancyp This was the discussion wherein we decided to use iframes. I would suggest we close this issue for now, and create a separate issue for the empty iframe thing. What do you say, @bethanyr @janiceilene ? :) | 
| Let's go ahead and create another issue to implement without iframes so you can control how the links open and we can merge this item in for now. | 
Description
As a contributor,
I need create a section on the newcomers page for first timer issues.
Fixes #252
TIme Taken:
24 hours (6 hours research + 2 hours implementation + 2 hours resolving merge conflicts on my local branch - all my PRs on the newcomers page is leading to a lot of conflicts + 3 hours reading about the iframe issue, Bethany mentioned about issues not being clickable - blank frame opening up+ 7 hours implementing a modular implementation, getting error at Array implementation, getting stuck at the unsafe URL error, looked up and tried solutions (mentioned on slack: https://systers-opensource.slack.com/archives/C99N86T43/p1532619465000180) + 3 hours - implemented less modular but working code using tabsets + 1 hour - added all projects info acc to their technology stack manually)
Type of Change:
Code/Quality Assurance Only
How Has This Been Tested?
Ran it locally
Checklist:
Code/Quality Assurance Only