This repository was archived by the owner on Feb 6, 2026. It is now read-only.
Conversation
…ories With the removal of SchemaVariantCategories, these tests need to be updated to not rely on them. We were previously using this MV to determine whether various Schemas used in tests were installed or not, as SDF still requires the caller to pass in this information. The following updates were made: - Add support for fetching the deployment index and deployment MVs - Create a test helper that creates the correct component payload, based on whether the schema in question is installed or not - Update all tests to use the new helper - Update 8-check_mjolnir, which was directly relying on SchemaVariantCategories to determine that a variant was installed when the component was created for it. Replace this with checking for the LuminorkDefaultVariant - Update 2-create_and_apply_across_change_sets to hardcode the `SchemaId` for the `TestResourceActions` Schema, which is a special asset we use only for that test that exists in the module index
We had disabled enqueuing the Edda task that would build the Deployment MVs, when the builtins are cached during migration as the task was taking 4ish hours. Now that this task completes rather quickly, let’s do this on migration again. This mostly improves the local dev experience so we don’t have to manually enqueue it to see the builtins available for component creation on startup.
Dependency Review✅ No vulnerabilities or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
Author
|
Successful run here in tools: https://github.com/systeminit/si/actions/runs/18625982473 |
jobelenus
approved these changes
Oct 19, 2025
jobelenus
deleted the
brit/sdf-api-tests-cant-rely-on-schema-variant-categories-mv
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How does this PR change the system?
With the removal of the SchemaVariantCategories MV, these tests need to be updated to not rely on them. We were previously using this MV to determine whether various Schemas used in tests were installed or not, as SDF still requires the caller to pass in this information.
The following updates were made:
SchemaIdfor theTestResourceActionsSchema, which is a special asset we use only for that test that exists in the module indexBonus:
We had disabled enqueuing the Edda task that would build the Deployment MVs, when the builtins are cached during migration as the task was taking 4ish hours. Now that this task completes rather quickly, let’s do this on migration again. This mostly improves the local dev experience so we don’t have to manually enqueue it to see the builtins available for component creation on startup.
Out of Scope:
We should really update SDF and Web to work like Luminork when creating new components. A job for another day.
How was it tested?
All tests pass locally, including various permutations of having variants installed or not.
In short: 🔗
via Billions on GIPHY