feat(luminork): Error when a user tries to update a readonly property #7438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or OpenSSF Scorecard issues found.Scanned FilesNone |
stack72
force-pushed
the
feat-luminork-error-on-create-only
branch
from
a9f2ddb to
37ad558
Compare
aaron-dernley
previously approved these changes
Oct 6, 2025
britmyerss
reviewed
Oct 6, 2025
lib/dal/src/attribute/attributes.rs
Outdated
| let component = Component::get_by_id(ctx, component_id).await?; | ||
| if component.resource(ctx).await?.is_some() { | ||
| let prop_id = AttributeValue::prop_id(ctx, target_av_id).await?; | ||
| let prop = Prop::get_by_id(ctx, prop_id).await?; |
Contributor
There was a problem hiding this comment.
let's switch this - first check if it's a create_only, and then, use Component::resource_by_id function as we don't need the full component here.
Contributor
|
@stack72 we should add coverage of this in an integration test too if we don't have it |
stack72
force-pushed
the
feat-luminork-error-on-create-only
branch
from
37ad558 to
7e82012
Compare
When a user tries to update a read-only prop, we should throw a 412.
Trying to change the KeyName of an AWS::EC2::KeyPair as the following request:
```
curl -X 'PUT' \
'http://localhost:5380/v1/w/01HPJ3K7RC486W9RPR3T0B6HS2/change-sets/01K6WQ2YG46GJYSXFA4S58F2EX/components/01K6WPWQX5VCJ2NETCDQ433VEP' \
-H 'accept: application/json' \
-H 'Content-Type: application/json' \
-d '{
"attributes": {
"/domain/KeyName": "updated-key-name
}
}'
```
now throws an error so that the user knows what the issue is:
```
{
"message": "attribute error: cannot update create-only property at path '/domain/KeyName' when component has a resource attached",
"statusCode": 412,
"code": null
}
```
stack72
force-pushed
the
feat-luminork-error-on-create-only
branch
from
7e82012 to
a8256f7
Compare
britmyerss
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIXES: BUG-1080
When a user tries to update a read-only prop, we should throw a 412.
Trying to change the KeyName of an AWS::EC2::KeyPair as the following request:
now throws an error so that the user knows what the issue is: