Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #696, a regression introduced in the v3.0 work:
generate_stream
andgenerate_output
Sort.Type_then_ID
assumes IDs are monotonically increasing. This is not true when there are multiple PBFs, as the subsequent PBF restarts its numbering.LeasedStore
assumed that there would be at most 1 PBF being read. This might be fixable by multiplyingthreadNum
by the number of PBFs to be read in the initializers here:tilemaker/src/tile_data.cpp
Lines 54 to 57 in 07e878f
For testing, I built a pmtiles with monaco + liechtenstein and verified they both showed up.
I think we could probably support lazy geometries, but have left it alone for now.