Skip to content

Let gatsby-plugin-theme-ui take base preset options #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
May 8, 2020
Merged

Let gatsby-plugin-theme-ui take base preset options #878

merged 11 commits into from
May 8, 2020

Conversation

@laurieontech
Copy link

@laurieontech laurieontech commented Apr 28, 2020 •
edited
Loading

This code allows users to pass in their base themes through the plugin options. They can do it by path or by requiring the package directly. Any local shadowing is respected and merged with the base preset.

This was referenced Apr 29, 2020
Merged
Closed
@laurieontech laurieontech marked this pull request as draft April 29, 2020 19:57
@laurieontech
Copy link
Author

laurieontech commented Apr 29, 2020

Making this a draft in order to execute the following:

  • Error/command for missing dependency
  • Remove moduleExportName which is only possible if we align on default for all existing presets (will create PRs)

@laurieontech
Copy link
Author

laurieontech commented Apr 30, 2020

This depends on #882 for some themes to work cleanly.

jxnblk
jxnblk approved these changes May 5, 2020
View reviewed changes
Copy link
Member

@jxnblk jxnblk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just merged #882 and this generally LGTM! :shipit:

@laurieontech laurieontech marked this pull request as ready for review May 6, 2020 18:55
jxnblk
jxnblk reviewed May 7, 2020
View reviewed changes
jxnblk
jxnblk reviewed May 7, 2020
View reviewed changes
LB and others added 3 commits May 7, 2020 14:46
@laurieontech laurieontech merged commit c973516 into master May 8, 2020
@laurieontech laurieontech deleted the add-options branch May 8, 2020 19:19
@hasparus hasparus mentioned this pull request May 10, 2020
Closed
@jxnblk jxnblk mentioned this pull request Jun 26, 2020
Open
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jxnblk jxnblk jxnblk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@laurieontech @jxnblk