-
Notifications
You must be signed in to change notification settings - Fork 679
feat: Add merging array of variants #1226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
9f6b6de
feat: initial make variants as array
atanasster 9643e96
use deepmerge.all and add test for function
atanasster 047e909
docs: update changelog
atanasster ac3151c
fix: missing variant merge, add docs by Lauchlan
atanasster 2612c3b
test: add test for multiple derived variants
hasparus 8159640
Merge remote-tracking branch 'origin/master' into variants-as-array
hasparus 9c87c52
chore: merge with master
hasparus da9a535
Merge branch 'master' into variants-as-array
atanasster 4d64610
feat: added getVariantValue to extract variants
atanasster 3b850c6
Update packages/components/test/index.js
atanasster 5063ddd
test: update snapshots
atanasster cc0c301
Merge branch 'master' into variants-as-array
hasparus 2f1ddb6
feat: add variant tuple to types
hasparus 771b845
ref(components): prefix unused parameter with _ to make TS happier
hasparus 3eb5de5
test: add temporary test
hasparus b4d9578
Merge branch 'develop' into variants-as-array
atanasster fccaefc
merge incoming changes
atanasster 8af8bad
docs: fix wording as suggested by lachlanjs
atanasster 94cc661
Merge branch 'develop' into variants-as-array
atanasster 3984a58
support variant array prop in sx
atanasster 1bd7c60
simplified test code
atanasster 3e5f716
test and docs for variant as a function
atanasster e1a10b1
Merge branch 'develop' into variants-as-array
lachlanjc a1f2a9a
Merge branch 'develop' into variants-as-array
lachlanjc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -62,7 +62,30 @@ For example, a secondary button style can be added to `theme.buttons.secondary` | |||||
| <Button variant="secondary">Secondary</Button> | ||||||
| ``` | ||||||
|
|
||||||
| ## Example Theme | ||||||
|
||||||
| ## Example Theme | |
| ## Example theme |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.