Correct the used of snprintf in owinterface_add #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
changed the title
jserv
requested changes
Nov 30, 2023
Contributor
jserv
left a comment
jserv
left a comment
There was a problem hiding this comment.
Read the article How to Write a Git Commit Message and rewrite your git commit messages.
The origin size value of snprintf in owinterface_add was ETH_ALEN, if the string size is too large, it will only allow ETH_ALEN - 1 characters to be copied into the buffer. However, the buffer starts from location inf_name + 1 and the last character must be '\0', which means that the buffer only has at most ETH_ALEN - 2 characters space left. So the size value in snprintf of owinterface_add should be ETH_ALEN - 1
vax-r
force-pushed
the
Fix_size_in_snprintf
branch
from
3b6fcd8 to
e5eb949
Compare
Collaborator
Author
I've made some modification to my commit message, please take a look when you have available time. |
rickywu0421
approved these changes
Dec 1, 2023
Contributor
|
Thank @vax-r for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The origin
sizevalue insnprintfofowinterface_addwasETH_ALEN, which will only allow ETH_ALEN - 1 characters to write in the buffer when string size is too long.However, since the buffer starts from
inf_name + 1, which only allowETH_ALEN - 1characters to be written into, plus the last character must be'\0', so we should only allowETH_ALEN - 2character to be written into the buffer.That's why I create the PR and fix the
sizevalue toETH_ALEN - 1