-
Notifications
You must be signed in to change notification settings - Fork 60
Add sound multiplexer auto-detection when building #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The full error log I mentioned above:
If you need to check any other information for this environment, feel free to let me know. |
Hi @Mes0903 , I would like to get your environment. Interestingly, the CI build test is passed. So I think there is some mystery in your actual environment as the configuration of your PortAudio detects with both JACK and PulseAudio. |
@Cuda-Chen Here are my test results. Alternatively, feel free to let me know what specific information you’d like me to provide (or which commands I should run?).
|
I think the problem is that this environment has both PulseAudio and JACK installed at the same time:
In the Makefile, once the check detects PulseAudio it skips the JACK test, yet the build log says the library is being built with support for both back-ends:
But due to the skip, we didnt add the I think the CI passes simply because it tests three separate cases for “no audio dev packages,” “PulseAudio only,” and “JACK only”, but it doesn't test the scenario where both PulseAudio and JACK are present simultaneously. |
Hi @Mes0903 , Thanks for pointing me out. |
BTW, in the build log mentioned above, I noticed several other libraries like "ASIHPI", "AudioIO", etc. My environment doesn't have these libraries installed so I cant test it, but could they potentially cause similar issues as well? |
Hi @Mes0903 ,
|
@Cuda-Chen I think the current issue is that PortAudio enables every host-API it finds on the system, which forces us to keep adding the corresponding link flags. Manually probing for each library and maintaining a hard-coded list of I think a cleaner approach is to:
I tried a quick implementation of the first option and it now builds and runs successfully on all three of my test machines. Below is the key points of the snippet:
With only ALSA enabled, the relevant part of the build log now reads:
Then we get a lean PortAudio build, link exactly the libraries we need. BTW, Im not familar with the syntax of Makefile, so maybe there is an better approach to do these stuff. |
Hi @Mes0903 , Thanks for the hint. |
b5796e3
to
c6cda7f
Compare
76e6b58
to
86511d5
Compare
Hi @Mes0903 , I just update my code as our discussion. |
No description provided.