Add necessary header for queue.h #17
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the order of headers should not affect the compilation. if no stdlib.h in queue.h, we would have when adjusting the order: In file included from queue.c:2: ./queue.h:73:42: error: unknown type name 'size_t' bool q_remove_head(queue_t *q, char *sp, size_t bufsize);
jserv
reviewed
Jan 30, 2020
| */ | ||
|
|
||
| #include <stdbool.h> | ||
| #include <stdlib.h> |
Contributor
There was a problem hiding this comment.
Shouldn't it be <stddef.h> instead?
Contributor
Author
There was a problem hiding this comment.
true, stddef.h is more appropriate. will do.
Contributor
|
Not effective |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the order of headers should not affect the compilation.
if no stdlib.h in queue.h, we would have when adjusting
the order:
In file included from queue.c:2:
./queue.h:73:42: error: unknown type name 'size_t'
bool q_remove_head(queue_t *q, char *sp, size_t bufsize);