Feature(qtest): Add the rand option to generate a random string #16
Conversation
YuShuanHsieh
force-pushed
the
feature/random-string
branch
from
e3f79ea to
aa43954
Compare
YuShuanHsieh
force-pushed
the
feature/random-string
branch
from
aa43954 to
aee0b75
Compare
|
The subject of git commit messages was inaccurate. It can be "Recognize 'RAND' parameter for insertions." |
| static void fill_rand_string(char *buf, size_t buf_size) | ||
| { | ||
| size_t len = 0; | ||
| while (len < MIN_RANDSTR_LEN) |
There was a problem hiding this comment.
What if buf_size < MIN_RANDSTR_LEN?
There was a problem hiding this comment.
That is a good question. But I think the function is for internal usage and both buf_size and minimum length are defined by MIN_RANDSTR_LEN and MAX_RANDSTR_LEN. So It may reduce the chance that maintainer set wrong numbers to cause segmentation fault. My question is do I still need to add a logic to prevent error occurred for these kind of functions?
There was a problem hiding this comment.
You can place FIXME or TODO comments for the above considerations.
There was a problem hiding this comment.
I decided to place TODO comments. And could you share your experiences about the question? Cause in my experience, I only make sure that the internal function works without much error checks. I want to know how do experienced programmers think. Thanks 😄
There was a problem hiding this comment.
I am thinking of the feasibility to re-use fill_rand_string to perform fuzzing: https://en.wikipedia.org/wiki/Fuzzing
Typically speaking, fuzzer might expect shorter strings to validate interpreter and/or qtest internals.
YuShuanHsieh
force-pushed
the
feature/random-string
branch
from
aee0b75 to
6635959
Compare
2 participants
No description provided.