Skip to content

Fix(trace): fix expected values and unknown address access #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jserv merged 2 commits into from
Jan 27, 2020
Merged

Fix(trace): fix expected values and unknown address access #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cac7abd
Fix the expected result after sorting
YuShuanHsieh Jan 26, 2020
13d38f6
Check the null queue before loop it during do sort
YuShuanHsieh Jan 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions qtest.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,16 +485,18 @@ bool do_sort(int argc, char *argv[])
exception_cancel();
set_noallocate_mode(false);

list_ele_t *e = q->head;
bool ok = true;
while (ok && e && --cnt) {
/* Ensure each element in ascending order */
/* FIXME: add an option to specify sorting order */
if (strcmp(e->value, e->next->value) > 0) {
report(1, "ERROR: Not sorted in ascending order");
ok = false;
if (q) {
list_ele_t *e = q->head;
while (ok && e && --cnt) {
/* Ensure each element in ascending order */
/* FIXME: add an option to specify sorting order */
if (strcmp(e->value, e->next->value) > 0) {
report(1, "ERROR: Not sorted in ascending order");
ok = false;
}
e = e->next;
}
e = e->next;
}

show_queue(3);
Expand Down
2 changes: 1 addition & 1 deletion traces/trace-04-ops.cmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ it bear
it gerbil
size
sort
rh dolphin
rh bear
rh
rh
rh
Expand Down
6 changes: 3 additions & 3 deletions traces/trace-05-ops.cmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ rh dolphin
reverse
size
sort
rh gerbil
rh bear
rh meerkat
rh gerbil
rh bear
rh gerbil
rh gerbil
rh meerkat
size
free