Add new command and associated test #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
reviewed
Feb 8, 2023
jserv
reviewed
Feb 8, 2023
jserv
reviewed
Feb 8, 2023
eecheng87
force-pushed
the
master
branch
2 times, most recently
from
820f12b to
de670c2
Compare
jserv
requested changes
Feb 8, 2023
Contributor
jserv
left a comment
jserv
left a comment
There was a problem hiding this comment.
Fix grammar mistakes in git commit message. Also, do follow the manner of How to Write a Git Commit Message.
This commit supports a new command 'merge', which merges queues into a queue in ascending order. Even if queues are not sorted, 'merge' can be called. However, we will get the wrong answer, which is detected immediately after the call. Besides, this commit forwards the declaration of 'qcontext_t' from qtest.c to queue.h. It is because that 'q_merge' needs to traverse the chain. Relative test bench is added into trace-03-ops.cmd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit support a new command 'merge', which merge queues into one sorted queue in ascending order. Besides, this commit forwards the declaration of 'qcontext_t' to queue.h since 'q_merge' needs to traverse the chain.
Relative test bench is added into trace-03-ops.cmd and the answer has been updated in
lab0-c-private.