Perform static analysis over git-tracked files only #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Instead of changing the options passed to Cppcheck, I would enforce filtered file listing with the aid of Git objects. |
|
I add the tracking list generated with command |
jserv
reviewed
Apr 9, 2020
scripts/pre-commit.hook
Outdated
| @@ -76,6 +75,7 @@ do | |||
| done | |||
|
|
|||
| # static analysis | |||
| git ls-files *.c > $FILE_LIST | |||
There was a problem hiding this comment.
Change to the following:
git ls-tree --full-tree -r --name-only HEAD | \
grep -v compat | grep -E "\.(c|cc|cpp|h|hh|hpp)\$" | \
xargs $CPPCHECK $CPPCHECK_OPTS >/dev/null
jserv
reviewed
Apr 9, 2020
scripts/pre-commit.hook
Outdated
| --suppress=duplicateBreak:http_parser.c \ | ||
| --suppress=shadowVariable:http_parser.c" | ||
| CPPCHECK_OPTS="-I. --enable=all --error-exitcode=1 --force $CPPCHECK_suppresses ." | ||
| FILE_LIST=.include_file |
|
Use |
jserv
reviewed
Apr 9, 2020
scripts/pre-commit.hook
Outdated
| FILE_LIST=.include_file | ||
|
|
||
| CPPCHECK_suppresses="--suppress=missingIncludeSystem" | ||
| CPPCHECK_OPTS="-I. --file-list=$FILE_LIST --enable=all --error-exitcode=1 --force $CPPCHECK_suppresses" |
There was a problem hiding this comment.
Ditto. Remove --file-list=$FILE_LIST.
|
The subject can be changed as
|
jserv
changed the title
|
Thanks for your advices! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cppcheck might fail when trying to check
http_parser.cSince
http_parser.cis been ignored from adding intocommit, we don't have to check it in pre-commit stage.
I add CPPCHECK_ignore into
scripts/pre-commit.hookto prevent Cppcheck from checking it.