Conversation
The dispatcher existed solely to route to a single subcommand, forcing every invocation, doc, and test script to spell "kbox image" for no disambiguation value. Collapse the wrapper and let kbox [OPTIONS] -- COMMAND run directly. Also fix a latent issue where a positional command after -- would override -c, and add unit tests for the positional and -c+extras paths. Change-Id: I3a927bb58163fc7528973e791b810ce6dc426fc2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dispatcher existed solely to route to a single subcommand, forcing every invocation, doc, and test script to spell "kbox image" for no disambiguation value. Collapse the wrapper and let kbox [OPTIONS] -- COMMAND run directly. Also fix a latent issue where a positional command after -- would override -c, and add unit tests for the positional and -c+extras paths.
Change-Id: I3a927bb58163fc7528973e791b810ce6dc426fc2
Summary by cubic
Simplifies the CLI by removing the
imagesubcommand. You now run commands askbox [OPTIONS] -- COMMAND, with cleaner parsing and clearer help.Refactors
imagesubcommand and dispatcher; options are parsed at the top level.-c CMD -- ARGSkeeps extra args and isn’t overridden by a positional command.-hhelp flag and update usage text.kbox_argswithkbox_image_args;kbox_parse_args(argc, argv, struct kbox_image_args*).kbox ...instead ofkbox image ....-cwith extra args.Migration
kbox imageinvocations withkbox.--to separate kbox options from the guest command.kbox --help(orkbox -h).kbox_parse_argssignature and types.Written for commit 0000353. Summary will update on new commits.