Fix memory leaks by halting the kernel#50
Merged
jserv merged 1 commit intosysprog21:mainfrom Apr 7, 2026
Merged
Conversation
To stop the running kernel, lkl_sys_halt needs to be called to release the allocated resources. Change-Id: Ic288db5c61a16915a16ff6f120d8885faecf19ca
Contributor
|
Thank @RinHizakura for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To stop the running kernel, lkl_sys_halt needs to be called to release the allocated resources.
This fixes the error reported by KASAN.
Summary by cubic
Halt the LKL kernel during cleanup to release resources and fix KASAN-reported memory leaks. Adds
kbox_halt_kernel()and uses it inkbox_run_imageon both error and shutdown paths.kbox_halt_kernel()wrappinglkl_sys_halt()with error logging; declaredlkl_sys_halt()inlkl-wrap.h.err_post_bootand callkbox_halt_kernel()in botherr_post_bootanderr_netfor consistent cleanup before network teardown.Written for commit 0000002. Summary will update on new commits.