Skip to content

thread-rcu: Fix the types in rcu.h and barrier counter #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2022

Conversation

linD026
Copy link
Collaborator

@linD026 linD026 commented May 8, 2022

rcu.h:

  • Fix the parameter type of smp_store_release(). The parameter that
    wants to store should be a pointer type.
  • Fix the type of tid in rcu_node.
  • Rename all the internal parameters in Linux kernel style API to
    make it more prettier.

main.c:

  • Fix the barrier counter that doesn't initialize after exit.

No function change.

Copy link
Contributor

@jserv jserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve the subject of this pull request and git commit message.

@linD026 linD026 force-pushed the master branch 2 times, most recently from 5ba7afb to b3eadd6 Compare May 8, 2022 15:09
@jserv jserv changed the title thread-rcu: Fix trivial problems thread-rcu: Fix type of smp_store_release and barrier May 8, 2022
Copy link
Contributor

@jserv jserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use "prettier" in the git commit message.

rcu.h:
- Fix the parameter type of smp_store_release(). The parameter that
  wants to store should be a pointer type.
- Fix the type of tid in rcu_node.
- Rename all the internal parameters in Linux kernel style API to
  make it more prettier.

main.c:
- Fix the barrier counter that doesn't initialize after exit.

No function change.
@linD026 linD026 changed the title thread-rcu: Fix type of smp_store_release and barrier thread-rcu: Fix the types in rcu.h and barrier counter May 9, 2022
@jserv jserv merged commit bfaf9a4 into sysprog21:master May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants