-
Notifications
You must be signed in to change notification settings - Fork 499
mqtt: only use http-proxy() if it is supported #3767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Build SUCCESS |
MrAnno
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for fixing this!
modules/mqtt/CMakeLists.txt
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't test cmake but looks good to me.
(local-built paho-mqtt under /usr/local/lib is not detected by cmake. This is not a regression, I've seen this before this PR. Maybe I'm doing something wrong when compiling paho-mqtt).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's okay. You can set CMAKE_MODULE_PATH manually, if you have non-system CMake exported targets.
Alternatively, you can configure syslog-ng to be installed under /usr/local (CMAKE_INSTALL_PREFIX), in that case, all other deps from /usr/local/ will be found automatically.
Signed-off-by: Attila Szakacs <attila.szakacs@oneidentity.com>
5584379 to
1cd134f
Compare
|
Build SUCCESS |
|
I did a fresh compile on openSUSE / SLES using this patch, and syslog-ng compiled successfully both on SLES and openSUSE Leap releases. |
Fixes #3765
Alternative fix possibilities, that I could not make work:
libpaho-mqtt-dev, but I could not find any.MQTTClient_connectOptionshas astruct_versionmember andMQTTClient_connectOptions_initializer, which sets it from a preprocessor macro. It seems like it could help, but I could not get useful information from it in compile time.No news entry is needed, because the
http-proxy()feature was not yet released.Signed-off-by: Attila Szakacs attila.szakacs@oneidentity.com