Skip to content

Conversation

@alltilla
Copy link
Collaborator

@alltilla alltilla commented Aug 27, 2021

Fixes #3765

Alternative fix possibilities, that I could not make work:

  • I checked, whether we can use leb version related preprocessor macros from libpaho-mqtt-dev, but I could not find any.
  • MQTTClient_connectOptions has a struct_version member and MQTTClient_connectOptions_initializer, which sets it from a preprocessor macro. It seems like it could help, but I could not get useful information from it in compile time.

No news entry is needed, because the http-proxy() feature was not yet released.

Signed-off-by: Attila Szakacs attila.szakacs@oneidentity.com

@kira-syslogng
Copy link
Contributor

Build SUCCESS

MrAnno
MrAnno previously approved these changes Aug 27, 2021
Copy link
Collaborator

@MrAnno MrAnno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for fixing this!

@MrAnno MrAnno added this to the syslog-ng-3.34 milestone Aug 27, 2021
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't test cmake but looks good to me.
(local-built paho-mqtt under /usr/local/lib is not detected by cmake. This is not a regression, I've seen this before this PR. Maybe I'm doing something wrong when compiling paho-mqtt).

Copy link
Collaborator

@MrAnno MrAnno Aug 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's okay. You can set CMAKE_MODULE_PATH manually, if you have non-system CMake exported targets.
Alternatively, you can configure syslog-ng to be installed under /usr/local (CMAKE_INSTALL_PREFIX), in that case, all other deps from /usr/local/ will be found automatically.

Signed-off-by: Attila Szakacs <attila.szakacs@oneidentity.com>
@kira-syslogng
Copy link
Contributor

Build SUCCESS

@czanik
Copy link
Collaborator

czanik commented Aug 30, 2021

I did a fresh compile on openSUSE / SLES using this patch, and syslog-ng compiled successfully both on SLES and openSUSE Leap releases.

@gaborznagy gaborznagy merged commit 43ef2be into syslog-ng:master Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

syslog-ng git snapshot does not compile on openSUSE after PR #3747

5 participants