loki() destination #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
HofiOne
requested changes
May 9, 2024
| @@ -0,0 +1,15 @@ | |||
| ## channel-args() | |||
|
|
|||
| | Type:| | | |||
There was a problem hiding this comment.
could you plz format these tables with spaces to see the table structure (equal-width columns, fields, here, and everywhere bellow as well)
| | Type:| | | ||
| |Default:| -| | ||
|
|
||
| *Description:* The `channel-args()` option is available in gRPC-based drivers. The option accepts name-value pairs and sets channel arguments defined in the [GRPC Core library documentation](https://grpc.github.io/grpc/core/group__grpc__arg__keys.html). |
There was a problem hiding this comment.
use the external_links.yml for external links plz (here, and everywhere bellow as well)
There was a problem hiding this comment.
fixed (I hope I used the external_links.yml correctly)
| id: adm-dest-loki-opt | ||
| --- | ||
|
|
||
| The `loki()` driver sends messages to a Loki Grafna database and has the following options: |
There was a problem hiding this comment.
fixed all typos
| ## template() | ||
|
|
||
| | Type:| template or template-function| | ||
| |Default:| $ISODATE $HOST $MSGHDR$MSG| |
There was a problem hiding this comment.
please use the now commonly used MACRO format ${MACRO} from now and on here and everywhere
| @@ -0,0 +1,25 @@ | |||
| --- | |||
| title: 'loki(): Storing messages in a Grafna Loki database' | |||
There was a problem hiding this comment.
small typo Grafna here and multiple places bellow
zsoltgyulai94
force-pushed
the
doc-loki-destination
branch
from
34fa1c4 to
d33e7a5
Compare
HofiOne
approved these changes
May 13, 2024
Signed-off-by: Zsolt Gyulai (zgyulai) <zsolt.gyulai@quest.com>
Signed-off-by: Zsolt Gyulai (zgyulai) <zsolt.gyulai@quest.com>
zsoltgyulai94
force-pushed
the
doc-loki-destination
branch
from
d33e7a5 to
b0d222c
Compare
HofiOne
added a commit
that referenced
this pull request
May 13, 2024
external link elements have a forbidden whitespace before the named keys Signed-off-by: Hofi <hofione@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documented Loki Grafana destination.
Included new reusable option snippets.