Pipe fifo file removal #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zsolt Gyulai (zgyulai) <zsolt.gyulai@quest.com>
kovgeri01
reviewed
Aug 22, 2024
| therefore it is not recommended to be used on special files like | ||
| /proc/kmsg. | ||
|
|
||
| **NOTE:** If the `fifo` file is deleted, syslog-ng OSE automatically recreates it. When a new `pipe()` is created, syslog-ng OSE continues to use the old file until the system is restarted. |
There was a problem hiding this comment.
Sorry my wording was a little bit confusing in the issue. I tried to describe the following scenario, but it was unclear. The process flows like this:
- The file is deleted.
- Then someone recreates the file (syslog-ng will not automatically recreate it).
- After the file is recreated syslog-ng will not read it even if there are no remaining writer on the old FIFO syslog-ng will still try to read the old one regardless until restart
There was a problem hiding this comment.
Thanks for clarifying, I modified the note. Hopefully it's correct now.
Signed-off-by: Zsolt Gyulai (zgyulai) <zsolt.gyulai@quest.com>
kovgeri01
previously approved these changes
Aug 22, 2024
kovgeri01
reviewed
Aug 23, 2024
Co-authored-by: Kovács Gergő Ferenc <kovgeri01@gmail.com> Signed-off-by: zsoltgyulai94 <147834757+zsoltgyulai94@users.noreply.github.com>
mrgarris0n
requested changes
Aug 26, 2024
Co-authored-by: Gergely Karácsonyi <64634678+mrgarris0n@users.noreply.github.com> Signed-off-by: zsoltgyulai94 <147834757+zsoltgyulai94@users.noreply.github.com>
|
All issues seem to have been resolved one way or another, can we merge this? @mrgarris0n @kovgeri01 |
mrgarris0n
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added note about required restart when making a new fifo file.