Skip to content

Conversation

@zsoltgyulai94
Copy link
Contributor

Added note about possible failure and workaround for pipe sources.

Signed-off-by: Zsolt Gyulai (zgyulai) <zsolt.gyulai@quest.com>
@zsoltgyulai94 zsoltgyulai94 requested a review from czanik August 15, 2024 09:15
@czanik
Copy link

czanik commented Aug 15, 2024

I'd rather add it to https://github.com/syslog-ng/syslog-ng.github.io/tree/a452ee2e51b374c5606ab4c04928b38400e278d7/doc/_admin-guide/060_Sources/110_Pipe as it is more generic information than just the create-dir() option. The reader might not reach this point of the documentation when in panic :-)

Signed-off-by: Zsolt Gyulai (zgyulai) <zsolt.gyulai@quest.com>
@zsoltgyulai94
Copy link
Contributor Author

Included the note there as well. I think it's good to have it in both places.

Copy link

@czanik czanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me.

Copy link
Contributor

@mrgarris0n mrgarris0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but please consider creating a snippet for duplicated content.

@zsoltgyulai94 zsoltgyulai94 merged commit 718f57f into syslog-ng:master Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants