🐛 Fix enabling IP address logic for HCloud #313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batistein
requested changes
Oct 13, 2022
There was a problem hiding this comment.
please update the docs: https://github.com/syself/cluster-api-provider-hetzner/blob/main/docs/reference/hcloud-machine-template.md
There is also typo enabled -> enable
janiskemper
force-pushed
the
fix/enable-ip-hcloud
branch
from
4e7342d to
dd48928
Compare
batistein
previously approved these changes
Oct 13, 2022
Currently, the user can only enable/disable IPv4 and IPv6 if there is no private network. However, since the enabling/disabling is independent of the public/private net, we remove this if clause. To make sure that users don't disable the IPv4 if there is no private net, we always enable it in that case. This is necessary for Hetzner load balancers, as they can only work with IPv4 of HCloud servers. Fix #312
janiskemper
force-pushed
the
fix/enable-ip-hcloud
branch
from
dd48928 to
bb93ba9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Currently, the user can only enable/disable IPv4 and IPv6 if there is no private network. However, since the enabling/disabling is independent of the public/private net, we remove this if clause.
To make sure that users don't disable the IPv4 if there is no private net, we always enable it in that case. This is necessary for Hetzner load balancers, as they can only work with IPv4 of HCloud servers.
Which issue(s) this PR fixes:
Fixes #312
TODOs: