Skip to content

(internal) Add validation test coverage #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2023
Merged

(internal) Add validation test coverage #16

merged 1 commit into from
Dec 13, 2023

Conversation

@ravinadhruve10
Copy link
Contributor

@ravinadhruve10 ravinadhruve10 commented Dec 8, 2023 •
edited
Loading

Coverage summary:

  • Added validation test coverage for SP module used by Posture & Identity Access
  • Added validation test coverage for webhook module used by Threat detection
  • Keeping the test structure in parity with other cloud providers repo (e.g AWS)
  • Added gitignore

Note: while this may not give us the full overage we need, its a start rather than having no coverage at all.

@ravinadhruve10 ravinadhruve10 marked this pull request as ready for review December 12, 2023 01:28
@ravinadhruve10 ravinadhruve10 requested a review from a team as a code owner December 12, 2023 01:28
@ravinadhruve10 ravinadhruve10 merged commit 850b209 into master Dec 13, 2023
@ravinadhruve10 ravinadhruve10 deleted the modules-validation-coverage branch December 13, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cgeers cgeers cgeers approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ravinadhruve10 @cgeers